Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unixfs symlinks on Gateway #8437

Open
ghost opened this issue Nov 8, 2016 · 1 comment
Open

Unixfs symlinks on Gateway #8437

ghost opened this issue Nov 8, 2016 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Nov 8, 2016

Right now the gateway doesn't handle symlinks, it just passes everything that's not a directory to unixfs/io.DagReader, which refuses to work on symlinks.

internalWebError: cannot currently read symlinks

Needed for the cdn.media.ccc.de mirror.

@ghost ghost self-assigned this Nov 18, 2016
@kevina kevina self-assigned this Dec 13, 2016
@ghost ghost removed their assignment Apr 14, 2017
@lidel
Copy link
Member

lidel commented Sep 15, 2021

Some relevant discussion happened in #3508

Quick takeaways on top of that thread:

  • I believe a HTTP redirect is an okay solution, however "the root" that stops .. from going further should end at the root of each CID, not the namespace
    • So in /ipfs/CID/foo/bar the /ipfs/CID/ is the content root, not /ipfs/ (CIDs should not share root for security reasons)
  • modern solution should account for native/subdomain and path addressing (https://docs.ipfs.io/how-to/address-ipfs-on-web/)

@lidel lidel closed this as completed Sep 15, 2021
@lidel lidel transferred this issue from ipfs/go-ipfs-gateway Sep 15, 2021
@lidel lidel reopened this Sep 15, 2021
@lidel lidel changed the title Deal with unixfs symlinks Unixfs symlinks on Gateway Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants