Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNS republisher ignores existing EOLs #7537

Closed
aschmahmann opened this issue Jul 12, 2020 · 1 comment · Fixed by #7627
Closed

IPNS republisher ignores existing EOLs #7537

aschmahmann opened this issue Jul 12, 2020 · 1 comment · Fixed by #7627
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@aschmahmann
Copy link
Contributor

It looks like the IPNS republisher ignores the EOL set in the original record.

Say Alice creates an IPNS record with and EOL of 10 years from now, but has a republisher rate of 4 hours. Alice will end up republishing a record with the same sequence number, path, TTL, etc. but with a shorter EOL (i.e. the Ipns.RecordLifetime set in the config file, which defaults to 24 hours).

This might just be as simple a fix as correcting these few lines, but we should check it out to be sure.

https://github.com/ipfs/go-ipfs/blob/231fab811d83322e61fe8d9c65d7bcd9fd6d243c/namesys/republisher/repub.go#L137-L139

@Stebalien thoughts?

@aschmahmann aschmahmann added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jul 12, 2020
@Stebalien
Copy link
Member

Stebalien commented Jul 13, 2020

Yeah, this just looks like a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants