Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API_ORIGIN doesn't work #1017

Closed
NodeGuy opened this issue Apr 5, 2015 · 2 comments · Fixed by #1215
Closed

API_ORIGIN doesn't work #1017

NodeGuy opened this issue Apr 5, 2015 · 2 comments · Fixed by #1215

Comments

@NodeGuy
Copy link

NodeGuy commented Apr 5, 2015

I set the API_ORIGIN environment variable to * to allow API access from the browser. I see the following line in the debug log:

16:54:43.529 INFO commands/h: Allowing API requests from origin: * handler.go:44

but the HTTP response doesn't include the Access-Control-Allow-Origin header as expected.
@jbenet
Copy link
Member

jbenet commented Apr 8, 2015

Interesting. may be worth git blame-ing the gateway files.

cc @mappum @cryptix

@NodeGuy
Copy link
Author

NodeGuy commented May 8, 2015

I'll fix this.

@NodeGuy NodeGuy mentioned this issue May 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CORS middleware handler to the API.
2 participants
@jbenet @NodeGuy