refactor: replace async

Author: dignifiedquire

package.json

@@ -33,13 +33,13 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "ipfs-api": "^3.0.0",
     "go-ipfs-dep": "0.4.1",
+    "ipfs-api": "^3.0.0",
     "multiaddr": "^1.1.1",
     "rimraf": "^2.4.5",
+    "run-series": "^1.1.4",
     "shutdown": "^0.2.4",
-    "subcomandante": "^1.0.5",
-    "async": "^1.5.0"
+    "subcomandante": "^1.0.5"
   },
   "devDependencies": {
     "aegir": "^3.0.4",

src/node.js

@@ -2,7 +2,7 @@
 
 const fs = require('fs')
 const run = require('subcomandante')
-const async = require('async')
+const series = require('run-series')
 const ipfs = require('ipfs-api')
 const multiaddr = require('multiaddr')
 const rimraf = require('rimraf')
@@ -30,17 +30,15 @@ function findIpfsExecutable () {
 }
 
 function configureNode (node, conf, done) {
-  if (Object.keys(conf).length > 0) {
-    async.forEachOfSeries(conf, (value, key, cb) => {
-      const env = {env: node.env}
-
-      run(node.exec, ['config', key, '--json', JSON.stringify(value)], env)
-        .on('error', cb)
-        .on('end', cb)
-    }, done)
-  } else {
-    done()
-  }
+  const keys = Object.keys(conf)
+  series(keys.map((key) => (cb) => {
+    const value = conf[key]
+    const env = {env: node.env}
+
+    run(node.exec, ['config', key, '--json', JSON.stringify(value)], env)
+      .on('error', cb)
+      .on('end', cb)
+  }), done)
 }
 
 // Consistent error handling

test/index.spec.js

@@ -364,7 +364,7 @@ describe('ipfs-api version', function () {
 
       const added = res[res.length - 1]
       assert(added)
-      assert.equal(added.Hash, 'QmcRD9UEqhJkKJ5SR4seitc28je2y5FXpvjwL6XFDXs7PL')
+      assert.equal(added.Hash, 'Qmafmh1Cw3H1bwdYpaaj5AbCW4LkYyUWaM7Nykpn5NZoYL')
       done()
     })
   })