This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Add object endpoints and cli commands #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbaiodias
force-pushed
the
feature/object
branch
from
a285ee7 to
b6c07a3
Compare
| throw err | ||
| } | ||
|
|
||
| console.log(JSON.stringify(obj)) |
Member
There was a problem hiding this comment.
does this print in the same way that go-ipfs does? I believe go-ipfs does some formatting rather then printing the obj directly
Member
Author
There was a problem hiding this comment.
Yes:
(last command was with a daemon running)
fbaiodias
force-pushed
the
feature/object
branch
2 times, most recently
from
b06415d to
69e16f0
Compare
fbaiodias
force-pushed
the
feature/object
branch
from
69e16f0 to
a0785af
Compare
Member
|
LGTM, going to merge this. Thank you @xicombd :D |
daviddias
added a commit
that referenced
this pull request
Mar 14, 2016
Add object endpoints and cli commands
This was referenced Apr 7, 2022
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented most of #58, except for the
object patchcommands as the http API changed for 0.4.0 and the spec isn't not finished yet (ipfs-inactive/http-api-spec#32 (comment))