refactor: bubble swarm up and make a module just for it, preprepare libp2p to be used directly from libp2p instance, take off cat alias, make ping into its own module #490
Conversation
| this.bitswap = bitswap(this) | ||
| this.ping = ping(this) |
There was a problem hiding this comment.
This should make it more obvious for folks to understand why this pieces are all attached here.
There was a problem hiding this comment.
Note for the future: We should use a more explicit DI than just through an object with all the things. It will make it easier for people that want to have their light ipfs nodes to understand what are the dependencies of each component that IPFS uses
There was a problem hiding this comment.
Strongly agree with the Note for the future
|
request: @dignifiedquire || @victorbjelkholm for a quick CR :) |
| const libp2p = require('./ipfs/libp2p') | ||
| const files = require('./ipfs/files') | ||
| const bitswap = require('./ipfs/bitswap') | ||
| const goOnline = require('./modules/go-online') |
There was a problem hiding this comment.
Why the renaming to modules. I agree ipfs isn't a great name, but modules isn't describing it much better. Maybe commands?
There was a problem hiding this comment.
what about 'components'?
…ibp2p to be used directly from libp2p instance, take off cat alias, make ping into its own module
* fix: wait for one key to be the required key not all Also, every returns true if there's no items in the list so this was returning a false positive. * fix: iteratee not updating list
No description provided.