This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
level-up #420
Merged
level-up #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2016
daviddias
force-pushed
the
feat/generic-spec-compliant
branch
from
e035dab
to
b28ae1f
Compare
…API (.replace) and make necessary changes to make it all work again
This was referenced Aug 20, 2016
daviddias
force-pushed
the
feat/generic-spec-compliant
branch
2 times, most recently
from
1ff5348
to
7ef9b92
Compare
|
@dignifiedquire @haadcode @JGAntunes @nginnever @shamb0t @victorbjelkholm @RichardLitt wanna CR this one? :) |
| "ipfs-bitswap": "^0.6.0", | ||
| "ipfs-api": "^6.0.3", | ||
| "ipfs-api": "^7.0.0", |
There was a problem hiding this comment.
@diasdavid this dep is repeated.
daviddias
force-pushed
the
feat/generic-spec-compliant
branch
from
7ef9b92
to
56904fd
Compare
|
@dignifiedquire have you seen this: Getting it on CI and locally with the new Aegir |
| @@ -132,7 +132,7 @@ describe('config', () => { | |||
| }) | |||
|
|
|||
| describe('get/set', () => { | |||
| it('get a config key value', (done) => { | |||
There was a problem hiding this comment.
will tackle all of the CLI tests after http-api compliance with #428
|
Applied the CR, going to wait for CI (node.js + browser) and open a issue about the aegir and the ES5 version. @dignifiedquire is already on top of it. |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was about making the generic commands interface-ipfs-core compliant, however, I learned that with the use of the latest ipfs-api (on a branch at a time, now released), that our http-api tests are very brittle, so I decided to make this PR something more in order to make js-ipfs-api more robust.