This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: fix flaky pubsub test #3761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the http client, when we subscribe to a topic we open a HTTP connection which we keep open for the duration of the subscription. When we unsubscribe we abort the connection but it can remain open for a little while after the abort, even if we try to wait on the `fetch` command ending before continuting, which leads to the topic still being present in the subs list, so retry asserting that the subs list is empty in the tests within a certain time window. Fixes this sort of error: ``` ipfs: 1) interface-ipfs-core over ipfs-http-client tests against go-ipfs ipfs: .pubsub.unsubscribe ipfs: should subscribe 5 handlers and unsubscribe once with no reference to the handlers: ipfs: AssertionError: expected [ Array(1) ] to deeply equal [] ipfs: + expected - actual ipfs: -[ ipfs: - "pubsub-tests-SVOFzpM5DtbcI7jBETrmm" ipfs: -] ipfs: +[] ```
This was referenced Sep 13, 2021
This was referenced Oct 15, 2021
This was referenced Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the http client, when we subscribe to a topic we open a HTTP connection which we keep open for the duration of the subscription.
When we unsubscribe we abort the connection but it can remain open for a little while after the abort, even if we try to wait on the
fetchcommand ending before continuting, which leads to the topic still being present in the subs list, so retry asserting that the subs list is empty in the tests within a certain time window.Fixes this sort of error: