Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

refactor: convert ping API to async/await #2671

Merged
merged 1 commit into from
Dec 13, 2019
Merged

refactor: convert ping API to async/await #2671

merged 1 commit into from
Dec 13, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Dec 12, 2019 •
edited
Loading

Depends on:

  • libp2p 0.27

@alanshaw alanshaw mentioned this pull request Dec 12, 2019
Closed
dirkmc
dirkmc approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanshaw alanshaw merged commit 0921a82 into feat/ipfsx-boot-and-add Dec 13, 2019
@alanshaw alanshaw deleted the refactor/ping-async-await branch December 13, 2019 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @dirkmc