Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

refactor: switch to async peer-id #2588

Closed
wants to merge 1 commit into from
Closed

refactor: switch to async peer-id #2588

wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 6, 2019

This PR switches to async "peer-id": "^0.13.4"

I originally made this for (#2566) before I realized it does not work with other deps that use non-async peer-id.

cc @alanshaw @vasco-santos @jacobheun to be aware of this

This is WIP, needs js-libp2p to use async peer-id first

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel
Copy link
Member Author

lidel commented Nov 6, 2019

What would be the next step here? peer-info? peer-book?
(i don't want to step on anyone's toes)

@achingbrain
Copy link
Member

Can please we hold off on merging this until libp2p upgrades it's dependency on peer id?

I also performed this upgrade but backed it out after finding that previously equal peer IDs were no longer equal because one module was using v0.12.x and another was using v0.13.x, hence the promisification of the v.0.12.x peer IDs in the codebase currently.

@lidel
Copy link
Member Author

lidel commented Nov 6, 2019

yes, 💯, forgot to make it clear:
this should be parked until libp2p and is deps use async peer-id

@daviddias daviddias added the status/blocked Unable to be worked further until needs are met label Nov 12, 2019
@lidel
Copy link
Member Author

lidel commented Dec 17, 2019

Superseded by #2680

@lidel lidel closed this Dec 17, 2019
alanshaw pushed a commit that referenced this pull request Dec 17, 2019
@alanshaw alanshaw deleted the feat/async-peer-id branch December 18, 2019 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants