This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Files Quest #156
Closed
Files Quest #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/cli/commands/files/cat.js
Outdated
| if (err) { | ||
| throw new Error(err) | ||
| } | ||
| res.on('data', (data) => { |
There was a problem hiding this comment.
you can just res.pipe(process.stdout)
daviddias
referenced
this pull request
in ipfs/js-ipfs-repo
May 2, 2016
| fs.mkdirSync(dir + filepath) | ||
| } catch (err) { | ||
| } | ||
| ws = fs.createWriteStream(dir + data.path) |
There was a problem hiding this comment.
maybe path.join is safer?
|
@Voxelot can you break this PR into two that
I'm requesting this because it seems that you are close, or even 100% done for the 1st and still a bit far from having the 2nd 100%. Currently, not having the 1st complete is blocking the pursuit of js-ipfs running on the browser with the Files API. This will also give you a chance to get a clean commit history for these PR's |
|
Closing this in favor of new HTTP branch and completion of CLI PR 204 |
This was referenced Feb 1, 2020
This was referenced Jan 20, 2022
This was referenced Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
- [x] add CLI (tuples suplied to new awesomeness importer) - [ ] progress bar - [x] fix path names - [x] add HTTP-API - [x] cat CLI - [x] throw daemon not supported err - [x] cat HTTP-API - [x] get CLI - [ ] add progress bar - [x] get HTTP-API - [ ] get JS-IPFS-API - [x] Fix add to respond to no path supplied - [x] fix INIT to place config with new importer - [x] Tests - [x] files add core - [x] files add cli - [x] files add http-api - [x] files cat core - [x] files cat cli - [x] files cat http-api - [x] files get core - [x] files get cli - [x] files get http-apiBlockers
- [x] unixfs-engine readable stream error issueCall to Action
@bgrieder if you are still interested in the files commands that you were working we would love some help on this PR. Finally organized everything into a place that we can collab. This should close pull 104
@xicombd as I get into writing the http things I could use some help if possible. I hear you are pro at these things :D
Let the quest begin!