Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

feat: expose Buffer on the dist version #523

Closed
@interfect

Description

@interfect

According to the API spec, you're supposed to pass a node Buffer, a node Readable stream, or an object containing one of those to the ipfs.files.add method. However, this project advertises the ability to use the implementation by including a <script> tag:

<script src="https://unpkg.com/ipfs/dist/index.min.js"></script>

If you do include that tag, you get a global Ipfs object, and you can indeed start up a node and go online. But since in the global namespace there is no Buffer or Readable stream implementation, what are you supposed to pass to ipfs.files.add? It would seem to be requiring types that can't be created outside it's fancy webpack module that hides all the node globals.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions