fix: js-ipfs daemon config params (#914)

* Fix js-ipfs daemon config params

  - Respect `--enable-experimental-pubsub`
  - Don't overload repo config with cli args (fixes #868)
  - Typo

* Treat cli args and config overload as seperate

- Add an extra parameter for `HttpAPI` for `cliArgs`

Author: sktt

src/cli/commands/daemon.js

@@ -16,7 +16,7 @@ module.exports = {
       default: false
     },
     'enable-pubsub-experiment': {
-      type: 'booleam',
+      type: 'boolean',
       default: false
     }
   },
@@ -25,7 +25,7 @@ module.exports = {
     console.log('Initializing daemon...')
 
     const repoPath = utils.getRepoPath()
-    httpAPI = new HttpAPI(process.env.IPFS_PATH, argv)
+    httpAPI = new HttpAPI(process.env.IPFS_PATH, null, argv)
 
     httpAPI.start((err) => {
       if (err && err.code === 'ENOENT' && err.message.match(/Uninitalized repo/i)) {

src/http-api/index.js

@@ -16,7 +16,7 @@ function uriToMultiaddr (uri) {
   return `/ip4/${ipPort[0]}/tcp/${ipPort[1]}`
 }
 
-function HttpApi (repo, config) {
+function HttpApi (repo, config, cliArgs) {
   this.node = undefined
   this.server = undefined
 
@@ -55,8 +55,8 @@ function HttpApi (repo, config) {
             start: true,
             config: config,
             EXPERIMENTAL: {
-              pubsub: true,
-              sharding: config && config.enableShardingExperiment
+              pubsub: cliArgs && cliArgs.enablePubsubExperiment,
+              sharding: cliArgs && cliArgs.enableShardingExperiment
             },
             libp2p: libp2p
           })