From bc72e3614d01dfd469987b95545942e4fb8fc722 Mon Sep 17 00:00:00 2001 From: David Dias Date: Sun, 25 Oct 2015 20:24:46 +0000 Subject: [PATCH] add run sequence --- .gitignore | 1 + gulpfile.js | 28 ++++++++++++++++++++-------- karma.conf.js | 2 +- package.json | 2 +- src/index.js | 2 +- test/tests.js | 4 +++- test/tmp-disposable-nodes-addrs.json | 2 +- 7 files changed, 28 insertions(+), 13 deletions(-) diff --git a/.gitignore b/.gitignore index 1db018319e..334f9f343f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ node_modules some-test.js npm-debug.log +sauce_connect.log diff --git a/gulpfile.js b/gulpfile.js index 946add2319..7e9b07ec2f 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -3,9 +3,13 @@ var Server = require('karma').Server var mocha = require('gulp-mocha') var ipfsd = require('ipfsd-ctl') var fs = require('fs') +var runSequence = require('run-sequence') -gulp.task('default', function () { - gulp.start('test:node', 'test:browser') +gulp.task('default', function (done) { + runSequence( + 'test:node', + // 'test:browser', + done) }) gulp.task('test:node', function (done) { @@ -19,16 +23,25 @@ gulp.task('test:node', function (done) { .once('end', function () { stopDisposableDaemons(daemons, function () { process.exit() + // done() }) }) }) }) gulp.task('test:browser', function (done) { - new Server({ - configFile: __dirname + '/karma.conf.js', - singleRun: true - }, done).start() + startDisposableDaemons(function (daemons) { + new Server({ + configFile: __dirname + '/karma.conf.js', + singleRun: true + }, finish).start() + + function finish () { + stopDisposableDaemons(daemons, function () { + done() + }) + } + }) }) function startDisposableDaemons (callback) { @@ -54,10 +67,9 @@ function startDisposableDaemons (callback) { throw err } - console.log('ipfs init done - ' + key) ipfsNodes[key] = node - console.log('ipfs config (bootstrap and mdns off) - ' + key) + console.log(' ipfs init done - (bootstrap and mdns off) - ' + key) ipfsNodes[key].setConfig('Bootstrap', null, function (err) { if (err) { diff --git a/karma.conf.js b/karma.conf.js index 5f896d5894..efa6d1eb6a 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -39,7 +39,7 @@ module.exports = function (config) { basePath: '', frameworks: ['browserify', 'mocha'], files: [ - 'test/test.js' + 'test/tests.js' ], exclude: [], preprocessors: { diff --git a/package.json b/package.json index 8a05ea948d..1d9f346c96 100644 --- a/package.json +++ b/package.json @@ -37,6 +37,7 @@ "karma-sauce-launcher": "^0.3.0", "mocha": "^2.3.3", "pre-commit": "^1.0.6", + "run-sequence": "^1.1.4", "standard": "^5.2.2", "uglify-js": "^2.4.24" }, @@ -44,7 +45,6 @@ "test": "./node_modules/.bin/gulp", "test:node": "./node_modules/.bin/gulp test:node", "test:browser": "./node_modules/.bin/gulp test:browser", - "lint": "./node_modules/.bin/standard", "build": "./node_modules/.bin/browserify -t brfs -s ipfsAPI -e ./src/index.js | tee dist/ipfsapi.js | ./node_modules/.bin/uglifyjs -m > dist/ipfsapi.min.js" }, diff --git a/src/index.js b/src/index.js index 388645e775..dc8c604fe0 100644 --- a/src/index.js +++ b/src/index.js @@ -138,7 +138,7 @@ function IpfsAPI (host_or_multiaddr, port) { self.swarm = { peers: command('swarm/peers'), - connect: argCommand('swarm/peers') + connect: argCommand('swarm/connect') } self.ping = function (id, cb) { diff --git a/test/tests.js b/test/tests.js index 74adcd563b..b99b150e61 100644 --- a/test/tests.js +++ b/test/tests.js @@ -50,7 +50,9 @@ describe('IPFS Node.js API wrapper tests', function () { } function dial () { - apiClients['a'].swarm.connect(addrs['b'], function (err) { + console.log(addrs) + apiClients['a'].swarm.connect(addrs['b'], function (err, res) { + console.log('->', res) if (err) { throw err } diff --git a/test/tmp-disposable-nodes-addrs.json b/test/tmp-disposable-nodes-addrs.json index bff99bd41d..638aeca28e 100644 --- a/test/tmp-disposable-nodes-addrs.json +++ b/test/tmp-disposable-nodes-addrs.json @@ -1 +1 @@ -{"b":"/ip4/127.0.0.1/tcp/52153","c":"/ip4/127.0.0.1/tcp/52166","a":"/ip4/127.0.0.1/tcp/52169"} \ No newline at end of file +{"a":"/ip4/127.0.0.1/tcp/56689","b":"/ip4/127.0.0.1/tcp/56694","c":"/ip4/127.0.0.1/tcp/56697"} \ No newline at end of file