Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Create .npmignore that doesn't omit dist #16

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jan 28, 2019

From what I can tell dist is just omitted due to .gitignore so I've added .npmignore that is just like original .gitignore except dist/ is removed.

I believe it should fix #15

@Gozala Gozala changed the title Create .npmignore that doesn't omit dist #15 Create .npmignore that doesn't omit dist Jan 28, 2019
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the PR @Gozala

Can you amend the commit message, in order to get the CI green?

@Gozala
Copy link
Contributor Author

Gozala commented Jan 30, 2019

@vasco-santos it's all green now! I did not realized there was commit message format in place

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@vasco-santos vasco-santos merged commit 7746dab into ipfs:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish browser bundles to npm to suppport unpkg
2 participants