Conversation
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
SgtPooki
suggested changes
Oct 26, 2023
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
the ipfs-webui issue could be related to vite's build process not pulling in wasm dependencies?
src/lib/hash-importer.ts
Outdated
Comment on lines
42
to
43
| encode: async (data: Uint8Array): Promise<Uint8Array> => { | ||
| const { digest } = await blake3Digest(data) |
Member
There was a problem hiding this comment.
You could pull the import down into this so we only import this library dynamically when we need it, and add as a peer/optional/optionalPeer. That may solve the ipfs-webui issue.
Contributor
Author
There was a problem hiding this comment.
Done and Done, however I didn't test the wasm issue.
Member
|
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
SgtPooki
changed the title
Plus some minor changes
SgtPooki
pushed a commit
that referenced
this pull request
Nov 30, 2023
* feat(blake3): ➕ Adding blake3-multihash Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> * feat(blake3): 👔 Adding blake3 hasher Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> * fix: ♻️ Addressing comments Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> * fix: 🔀 Marking dep as peerDep Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> --------- Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
## [5.1.0](v5.0.0...v5.1.0) (2023-11-30) ### Features * **hasher:** add blake3 ([#395](#395)) ([6ea74e5](6ea74e5))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #394
In this PR:
@SgtPooki when trying to build ipfs-webui locally with this, it fails:
The error generates from here: https://github.com/web3-storage/blake3-multihash/blob/main/gen/wasm.js#L231 any ideas on how to test this?