Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs additional click to navigate on Web UI #762

Open
hacdias opened this issue Dec 21, 2018 · 2 comments
Open

Needs additional click to navigate on Web UI #762

hacdias opened this issue Dec 21, 2018 · 2 comments
Labels
area/webui Issues specific to interaction with ipfs-webui area/windows Windows effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hacdias
Copy link
Member

hacdias commented Dec 21, 2018

When I open the Web UI and click on one of the menu options to navigate, I need to click it twice. Only happens on the first one:

ex
@hacdias hacdias added kind/bug A bug in existing code (including security flaws) UX labels Dec 21, 2018
@hacdias hacdias added the area/windows Windows label Mar 11, 2019
@hacdias hacdias added the P2 Medium: Good to have, but can wait until someone steps up label Jul 24, 2019
@hacdias hacdias changed the title UX on Windows: needs additional click to navigate on Web UI Needs additional click to navigate on Web UI Jul 24, 2019
@hacdias hacdias mentioned this issue Nov 29, 2019
Closed
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@SgtPooki SgtPooki mentioned this issue Jul 10, 2023
Merged
@SgtPooki SgtPooki moved this from Needs Grooming to Prioritized / Ready for Dev in IPFS-GUI (PL EngRes) Jul 10, 2023
@SgtPooki SgtPooki added status/ready Ready to be worked effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful area/webui Issues specific to interaction with ipfs-webui labels Jul 10, 2023
@SgtPooki
Copy link
Member

Note: I believe we need to debug this by looking into https://www.electronjs.org/docs/latest/api/web-contents#navigation-events and make sure that first click is being handled. If it's not being handled by webContents then maybe webContents doesn't have the focus? or we're showing the window BEFORE whatever other event we're listening to focuses on the webContent?

I just did some testing.. it look like some method is chopping up the URL incorrectly on first click:

2023-07-10T03:56:20.646Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50-4065-4643-9fcf-790de67cd9f7&lng=&api=%2Fip4%2F127.0.0.1%2Ftcp%2F5001#/
2023-07-10T03:56:20.647Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50-4065-4643-9fcf-790de67cd9f7&lng=&api=%2Fip4%2F127.0.0.1%2Ftcp%2F5001#/
2023-07-10T03:56:20.652Z info: [window:webContents:did-frame-navigate] navigation to webui://-/?deviceId=af6e2d50-4065-4643-9fcf-790de67cd9f7&lng=&api=%2Fip4%2F127.0.0.1%2Ftcp%2F5001#/
2023-07-10T03:56:20.652Z info: [window:webContents:did-navigate] navigation to webui://-/?deviceId=af6e2d50-4065-4643-9fcf-790de67cd9f7&lng=&api=%2Fip4%2F127.0.0.1%2Ftcp%2F5001#/

The page had finished loading at this point, and then I tried clicking a tab, and I got all the below output:

2023-07-10T03:56:38.388Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.388Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.388Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.389Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.389Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.389Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50
2023-07-10T03:56:38.428Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:38.428Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:38.428Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:38.429Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:38.429Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:38.429Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50#/
2023-07-10T03:56:41.184Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/blank
2023-07-10T03:56:41.184Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/blank
2023-07-10T03:56:41.185Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50#/blank

and upon re-clicking:

2023-07-10T03:58:43.176Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/files
2023-07-10T03:58:43.177Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/files
2023-07-10T03:58:43.177Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50#/files
2023-07-10T03:58:43.177Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/files
2023-07-10T03:58:43.177Z info: [window:webContents:did-start-navigation] navigation to webui://-/?deviceId=af6e2d50#/files
2023-07-10T03:58:43.178Z info: [window:webContents:did-navigate-in-page] navigation to webui://-/?deviceId=af6e2d50#/files

@SgtPooki SgtPooki self-assigned this Jul 10, 2023
@SgtPooki SgtPooki mentioned this issue Jul 11, 2023
Open
@SgtPooki SgtPooki moved this from Prioritized / Ready for Dev to In Progress in IPFS-GUI (PL EngRes) Aug 1, 2023
@SgtPooki
Copy link
Member

i've looked into this a number of times and the fix is not obvious and will require some deeper diving I don't currently have time for.

@SgtPooki SgtPooki removed their assignment Oct 12, 2023
@SgtPooki SgtPooki added effort/days Estimated to take multiple days, but less than a week and removed effort/hours Estimated to take one or several hours labels Oct 12, 2023
@SgtPooki SgtPooki moved this from In Progress to Planned / Backlog in IPFS-GUI (PL EngRes) Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/webui Issues specific to interaction with ipfs-webui area/windows Windows effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Planned / Backlog
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

762-needs-additional-click-to-navigate-on-web-ui ipfs/ipfs-desktop
3 participants
@SgtPooki @jessicaschilling @hacdias