Can't install IPFS updates if notifications are disabled

[dullbananas]

• macOS 12.4
• Version of IPFS Desktop: unknown, older than 0.21.0

Describe the bug
If notifications are enabled, then a notification appears that lets me update IPFS. If they're disabled, then I can't update IPFS.

To Reproduce
Steps to reproduce the behavior:

1. Disable notifications for IPFS Desktop
2. Select "About" > "Check for Updates..." in the menu bar icon
3. Select "Install Now"
4. Wait for IPFS to restart
5. Select "About" > "Check for Updates..." in the menu bar icon
6. Update is still available

Expected behavior
Update should be installed

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[SgtPooki]

Thanks for submitting this issue, I will attempt to reproduce

[hacdias]

@SgtPooki this seems to be an issue indeed. I installed 0.20.6 to try it out. Repeating the steps ("About" -> "Check For Updates" -> "Install Now") restarts IPFS Desktop but the updates are not applied. This happens ad infinitum, or at least for the 10 times I tried. However, if we click the notification, which shows the same popup and we click Install Now, then it works

Looking at the code, it is not clear to me why this is happening as the mechanism was working before, albeit not the first time that it fails... I don't have much bandwidth to deal with this. My recommendation would be to create a personal repository with a fork of IPFS Desktop and try to debug the auto update mechanism since we can't debug it easily.

[SgtPooki]

Thanks for confirmation @hacdias. We will look into this further at a later point, but I will adjust priority