Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow test file: test/e2e/launch.e2e.test.js (42s) #2116

Open
SgtPooki opened this issue Apr 29, 2022 · 3 comments
Open

Slow test file: test/e2e/launch.e2e.test.js (42s) #2116

SgtPooki opened this issue Apr 29, 2022 · 3 comments
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/deferred Conscious decision to pause or backlog

Comments

@SgtPooki
Copy link
Member

We should optimize and speed up these tests.

npm run test:e2e

> ipfs-desktop@0.20.5 test:e2e
> xvfb-maybe cross-env NODE_ENV=test playwright test test/e2e/launch.e2e.test.js


Running 10 tests using 1 worker

  ✓  test/e2e/launch.e2e.test.js:66:3 › Application launch › creates a repository on startup (5s)
  ✓  test/e2e/launch.e2e.test.js:80:3 › Application launch › starts fine when node is already running (4s)
  ✓  test/e2e/launch.e2e.test.js:88:3 › Application launch › applies config migration (MDNS.enabled) (4s)
  ✓  test/e2e/launch.e2e.test.js:109:3 › Application launch › applies config migration (Web UI CORS 1) (4s)
  ✓  test/e2e/launch.e2e.test.js:131:3 › Application launch › applies config migration (Web UI CORS 2) (4s)
  ✓  test/e2e/launch.e2e.test.js:152:3 › Application launch › applies config migration (Web UI CORS 3) (4s)
  ✓  test/e2e/launch.e2e.test.js:173:3 › Application launch › applies config migration (ConnMgr) (4s)
  ✓  test/e2e/launch.e2e.test.js:194:3 › Application launch › starts with repository with "IPFS_PATH/api" file and no daemon running (6s)
  ✓  test/e2e/launch.e2e.test.js:210:3 › Application launch › starts with multiple api addresses (4s)
  ✓  test/e2e/launch.e2e.test.js:222:3 › Application launch › starts with multiple gateway addresses (4s)

  Slow test file: test/e2e/launch.e2e.test.js (42s)
  Consider splitting slow test files to speed up parallel execution

  10 passed (42s)
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Apr 29, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented May 16, 2022

they're using unique repos, but i'm not sure if they're using unique HOME for these tests. We should check if we can parallelize these - @lidel

@SgtPooki SgtPooki added P3 Low: Not priority right now exp/beginner Can be confidently tackled by newcomers status/deferred Conscious decision to pause or backlog help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization exp/beginner Can be confidently tackled by newcomers labels May 16, 2022
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@hacdias
Copy link
Member

hacdias commented Sep 5, 2022

We do use unique HOMEs for these tests. Another consideration to have is that the IPFS daemon must always start on different ports.

@Gulu888
Copy link

Gulu888 commented Sep 13, 2022

Help wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/deferred Conscious decision to pause or backlog
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

3 participants