Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Check for updates via menu-bar sub-menu action (macOS) #2113

Open
SgtPooki opened this issue Apr 28, 2022 · 2 comments
Open

Bug: Check for updates via menu-bar sub-menu action (macOS) #2113

SgtPooki opened this issue Apr 28, 2022 · 2 comments
Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up topic/macos MacOS specific

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Apr 28, 2022 •
edited
Loading

  • OS: macOS
  • Version of IPFS Desktop [0.20.0]

Describe the bug
Using latest version of ipfs-desktop, manually selecting to check for updates locks up the UI when the desktop application is not open.

To Reproduce
Steps to reproduce the behavior(macos):

  1. Start ipfs-desktop
  2. Ensure the menu-bar application is visible, and then close the ipfs-desktop window (the application will still be running, and accessible via the menu-icon)
  3. Click the ipfs-desktop menu-bar icon
  4. Hover over about
  5. Click on 'Check for updates'
    • The sub-menu may close (I believe this is only on the newest version). If it does, re-open it before the update-checking is done in order to reproduce the bug.
  6. Notice that the UI for the menu-bar ipfs menu locks up

The ipfs-desktop application will re-open in the dock with a pop-up confirmation indicating that you are on the latest version.

Expected behavior
Checking for updates is a non-blocking background operation.

Screenshots
Action:
image

Locked up UI:
image

Latest version confirmation popup:
image

Additional context
When I first ran into this bug, the Dock did not display the ifps-desktop icon. So I was unable to close the confirmation popup, and the UI stayed locked up, with the menu-bar menu remaining open and inaccessible.

combined.log
error.log
@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up area/macos MacOS need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding effort/hours Estimated to take one or several hours topic/macos MacOS specific labels Apr 28, 2022
@SgtPooki SgtPooki changed the title Bug: Check for updates via menu-bar sub-menu action Bug: Check for updates via menu-bar sub-menu action (macOS) Apr 28, 2022
@hacdias
Copy link
Member

hacdias commented May 2, 2022 •
edited
Loading

Checking for updates is a non-blocking background operation.

On my computer, the menubar does not lock during the update checking as it is a background operation. It locks, indeed, after the dialog shows up. But not in the time between clicking and waiting for the dialog. However, I think that is a limitation from Electron as both the menubar and the dialog are being rendered from the main process. That is something that needs to be investigated.

An alternative would be to display a window a custom dialog, as we do in other places instead of using the native dialogs. In that case, the menubar wouldn't probably get stuck in that 'locked' state.

@SgtPooki
Copy link
Member Author

SgtPooki commented May 9, 2022

I think the refactor of ctx will go a long way towards improving this. We have a lot of async-ux things being done by non-async functions.

@lidel lidel mentioned this issue May 23, 2022
Closed
@lidel lidel removed the need/triage Needs initial labeling and prioritization label May 23, 2022
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@SgtPooki SgtPooki removed their assignment Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up topic/macos MacOS specific
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @hacdias