Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS status isn't reflected in the system tray menu if connected to a remote node #1836

Open
andrasfuchs opened this issue Jun 9, 2021 · 3 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@andrasfuchs
Copy link

  • OS: Windows 10
  • Version of IPFS Desktop 0.15.0

Describe the bug
I connect my IPFS Desktop installation on Windows to another IPFS node on my Raspberry Pi on my local network. The connection is established correctly, but certain system tray menu items like Status / Files / Peers are disabled. If I open the UI of IPFS Desktop all the pages are fine, showing the status / files / peers of my remote node.

To Reproduce
Steps to reproduce the behavior:

  1. Install an IPFS node on your local network
  2. Start IPFS Desktop on another computer
  3. Change the API address to the remote one
  4. Right click on the system tray icon
  5. You will see that certain items are disabled

Expected behavior
I would expect to see the Status / Files / Peers menu items enabled.
Also it would be great if the IPFS node status on the top of the tray menu and the tray icon itself would show the status of the currently connected (remote) node.

Screenshots
We are connected to the remote node, but the tray menu doesn't reflect that:
image

Setup of the remote API address:
image

@andrasfuchs andrasfuchs added the need/triage Needs initial labeling and prioritization label Jun 9, 2021
@lidel
Copy link
Member

lidel commented Jun 11, 2021

Changing API address applies only to WebUI. Everything else reflects local node that ships with IPFS Desktop.
That is why you see remote API in webui, but desktop tray menu is still disabled.

The fix here is to either:

  • (A) hide "API Address" inputs when webui is running inside of IPFS Desktop
  • (B) make IPFS Desktop aware of "API address" changes made inside of webui

(A) is easy, (B) is tricky because it is unclear how to indicate "stop using remote API, restore running built-in node"
Unless we find an intuitive way to solve (B), I suggest fixing the UX gap with (A).

@lidel lidel added effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up help wanted Seeking public contribution on this issue and removed need/triage Needs initial labeling and prioritization labels Jun 11, 2021
@andrasfuchs
Copy link
Author

andrasfuchs commented Jun 12, 2021

My suggestion would probably be an overkill, because I'm not sure how many people would like to manage multiple nodes with one IPFS Desktop instance, but theoretically we could change the UI to handle multiple node addresses and switch among them.

I would imagine something like this on the Settings page:
image

What do you think?

@lidel
Copy link
Member

lidel commented Sep 6, 2021

I like it, this would make a nice feature for ipfs-webui for power users,
but needs additional work if we want to show API ADDRESS section in ipfs-desktop, namely make a clear distinction between node managed by Desktop app and a remote one.

FYSA for now we went with (A) and the next release with ipfs-webui v2.13.0 (#1903) will be hiding API selection in Desktop app for now, to reduce user confusion described in the beginning of this issue.

Won't have bandwidth for more than that for the time being, but if someone submits a PR with (B) and the UI you proposed, I'm happy to review and accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants