This repository was archived by the owner on Aug 1, 2023. It is now read-only.
chore: update tests to async await #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroMiguelSS
requested review from
achingbrain,
hugomrdias and
vasco-santos
PedroMiguelSS
force-pushed
the
chore/update-tests-to-async-await
branch
2 times, most recently
from
ce990bd to
c147efd
Compare
Member
|
CI still red and conflicts can you fix this so we can review ? |
vasco-santos
suggested changes
Oct 7, 2019
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
I made a first pass through this
PedroMiguelSS
force-pushed
the
chore/update-ipfsd-ctl
branch
from
facc384 to
4f38311
Compare
achingbrain
suggested changes
Oct 22, 2019
Member
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
Nothing major, great work - let's get this in.
PedroMiguelSS
force-pushed
the
chore/update-tests-to-async-await
branch
from
c147efd to
159246d
Compare
Contributor
Author
|
I've committed the requested changes. Can you review it again, please? @achingbrain @vasco-santos |
Member
|
This is great - so nearly there. Two final, final things:
|
Contributor
Author
|
Done @achingbrain! |
Member
|
@PedroMiguelSS see error's on CI: https://travis-ci.com/ipfs/interop/jobs/250668939#L329-L372 can you figure out why it is failing? |
Member
|
🎉👏❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all the tests to use async/await.
It completes phase number 4 to tackle #87 as referenced here.