-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: iterable pinning #231
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e09b945
feat!: update the interfaces for batching and iteration.
saul-jb 23dc18c
feat!: update pins add to be interable and batchable.
saul-jb 5cf4ca1
chore: remove redundant p-defer.
saul-jb 9795cc4
test: update to new implementation.
saul-jb 4c217f7
feat!: update pins rm to be iterable
saul-jb 7c5e895
feat!: update pins rm to be interable.
saul-jb 2df091b
chore: remove redundant p-queue package.
saul-jb b5818ae
test: update tests to the new pin rm signature.
saul-jb a01738c
test: update interop test to new interfaces.
saul-jb 417ed31
chore: update benchmark scripts
saul-jb d8a9a21
chore: linting
saul-jb 1d36b37
feat: add support for changing batch size dynamically
saul-jb c97774f
test: fix interop pins test
saul-jb bc38555
fix: make the default batch number a reasonable value
saul-jb 16929e0
feat: add option for syncing local values first
saul-jb ad35c6b
refactor: change to standard iterables
saul-jb 82c13d6
refactor: change map to parallel
saul-jb 394500d
fix: remove last type from add generator
saul-jb 952db49
Merge branch 'main' into feat/iterable-pin
saul-jb 9111576
Merge branch 'main' into feat/iterable-pin
achingbrain dd25d1e
Merge branch 'main' into feat/iterable-pin
achingbrain 0a8f5ba
Merge branch 'main' into feat/iterable-pin
SgtPooki 7f9dbb5
test(pins): use generator syntax
SgtPooki 3490a4f
fix: support resumable pinning
SgtPooki 8034239
chore: fix test
achingbrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achingbrain I pulled this out into a locally defined interface and added some context