Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Concurrent walk test #106

Merged

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Sep 1, 2021

All the numbers and estimations need to be checked later. The purpose of this review is to check if this was the design requested in #99 (comment).

The main issue here is that for TestHAMTEnumerationWhenComputingSize to pass we now need a low-level understanding of the dag.Walk function when called with the Concurrent option (an example of this is that we are copying one of its internal variables, defaultConcurrentFetch, in order to anticipate how many DAGService.Get() requests will roughly be issued).

Another example of the above is that confusingly WalkDepth is not necessarily a DFS. "Depth" here just means that the depth of the link being visited is passed to the callback but in practice the traversal is:

@schomatis schomatis self-assigned this Sep 1, 2021
@schomatis schomatis mentioned this pull request Sep 1, 2021
@schomatis schomatis marked this pull request as ready for review October 12, 2021 18:56
@schomatis schomatis merged commit cdcb270 into schomatis/directory/unsharding-tests Oct 12, 2021
@schomatis schomatis deleted the schomatis/concurrent-walk-test branch October 12, 2021 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants