This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the numbers and estimations need to be checked later. The purpose of this review is to check if this was the design requested in #99 (comment).
The main issue here is that for
TestHAMTEnumerationWhenComputingSize
to pass we now need a low-level understanding of thedag.Walk
function when called with theConcurrent
option (an example of this is that we are copying one of its internal variables,defaultConcurrentFetch
, in order to anticipate how manyDAGService.Get()
requests will roughly be issued).Another example of the above is that confusingly
WalkDepth
is not necessarily a DFS. "Depth" here just means that the depth of the link being visited is passed to the callback but in practice the traversal is:sequentialWalkDepth
is a recursive algorithm and hence DFS approach,parallelWalkDepth
a FIFO queue is used and hence we have a BFS approach.