This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: remove HashOnRead #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Apr 12, 2020
validating_blockstore.go
Outdated
| // ValidatingBlockstore validates blocks on get, if enabled. | ||
| type ValidatingBlockstore struct { | ||
| Blockstore | ||
| ValidateGet bool |
There was a problem hiding this comment.
The use of the wrapper already serves as this bool. remove it and just decide if you want to wrap an underlying blockstore with this wrapper.
There was a problem hiding this comment.
I put that there so we could also introduce validations for put. But you're right, that's probably not necessary.
willscott
approved these changes
Apr 12, 2020
Instead, provide a simple `ValidatingBlockstore` wrapper. This: 1. Isn't racy (fixes #49). 2. Keeps the base blockstore simple.
Stebalien
force-pushed
the
fix/validate-get
branch
from
c50a442
to
1df2299
Compare
❗ This repository is no longer maintained.This repository is no longer maintained and this library has been copied over to In an effort to avoid noise and crippling in the Boxo repo from the weight of issues of the past, we are closing most issues and PRs in this repo. This topic is continued in ipfs/boxo#365 You can learn more in the FAQs for the Boxo repo copying/consolidation effort. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, provide a simple
ValidatingBlockstorewrapper. This:Really, "HashOnRead" should never have been a part of the blockstore API in the
first place.