Skip to content

Conversation

@guseggert
Copy link
Contributor

@guseggert guseggert commented Dec 3, 2021

also @obo20 you may be interested in this

@welcome
Copy link

welcome bot commented Dec 3, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@guseggert guseggert force-pushed the feat/datastore-contexts branch from 04beef1 to 4f72b8a Compare December 3, 2021 03:17
@guseggert guseggert marked this pull request as ready for review December 3, 2021 03:25
@guseggert guseggert requested a review from MichaelMure December 3, 2021 03:29
Copy link
Collaborator

@MichaelMure MichaelMure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice at some point to have a way to wrap the AWS session in Config to add tracing.

@guseggert
Copy link
Contributor Author

Looks good. It would be nice at some point to have a way to wrap the AWS session in Config to add tracing.

True, we can follow up with that as it can be backwards-compatible.

@guseggert
Copy link
Contributor Author

Also re: releasing this, I can tag this as 0.8.0 and create the GH release, does that sound good?

@guseggert guseggert merged commit 1ad440b into master Dec 13, 2021
@guseggert guseggert deleted the feat/datastore-contexts branch December 13, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants