Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.16 is EOL #156

Open
Luflosi opened this issue Apr 15, 2022 · 3 comments
Open

Go 1.16 is EOL #156

Luflosi opened this issue Apr 15, 2022 · 3 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@Luflosi
Copy link
Contributor

Luflosi commented Apr 15, 2022

Go 1.16 is no longer supported since Go 1.18 was released.
Unfortunately, fs-repo-migrations does not work with Go 1.17. See #122 (comment) and NixOS/nixpkgs@2ff6ffe for previous mentions and more detailed explanations of this issue.
Since Go 1.16 is EOL, it will start to be removed in repositories, here for example in NixOS: NixOS/nixpkgs#168480. This will cause fs-repo-migrations to no longer work there.
I would like fs-repo-migrations to be updated to support a current Go version or at least clearly document, which migration is compatible with which Go version.

@Luflosi Luflosi added the need/triage Needs initial labeling and prioritization label Apr 15, 2022
@aschmahmann
Copy link
Contributor

I would like fs-repo-migrations to be updated to support a current Go version

The issue here is that fs-repo-migrations has a dependency on quic-go via a dependency on go-ipfs. If you're wondering why quic-go is tied to a specific Go version see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions.

Ideally we'd be able to remove the quic-go dependency for migrations so we don't have to worry about this anymore.

or at least clearly document, which migration is compatible with which Go version.

This seems like an actionable item. Every migration should work with building up to Go 1.16 (although 1.15 should also work). Subsequent migrations will either be built with a later version and document or, better, we can remove the quic-go issue from fs-repo-migrations so you don't have to worry about it here.

@sk33z3r
Copy link

sk33z3r commented Jun 13, 2022

I am unable to use IPFS on NixOS as of NixOS 22.05, due to Go 1.18 and 1.17 being the only available Go packages for NixOS in this version.

@Huy-Ngo
Copy link

Huy-Ngo commented Jun 19, 2022

The issue here is that fs-repo-migrations has a dependency on quic-go via a dependency on go-ipfs. If you're wondering why quic-go is tied to a specific Go version

It seems newer version of quic-go added support for go 1.17 and 1.18:

We currently support Go 1.16.x, Go 1.17.x, and Go 1.18.x.
(from the README)

Is it possible to build this with newer version of quic-go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants