Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of yarn release #548

Open
lidel opened this issue Apr 22, 2020 · 0 comments
Open

Improve UX of yarn release #548

lidel opened this issue Apr 22, 2020 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Apr 22, 2020

If package.json has:

"scripts": {
 "release": "aegir release"

and I run yarn release instead of npm run release it fails at the very last stage of publishing to NPM:

npm ERR! 401 Unauthorized - PUT https://registry.yarnpkg.com/is-ipfs - You must be logged in to publish packages.

I did not look at the URL and assumed i got logged out from NPM, to I've run npm login and then retried with yarn release, which failed again 🙃

I feel bit ashamed that it took me two retries to squint and see that its yarnpkg.com, but I suspect most of folks would do the same, so perhaps it worth addressing somehow?

Are we able to fix this so it just works under yarn?
If not, at least detect release runs under yarn and simply return error asking to run it via npm ?

@hugomrdias hugomrdias added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants