Filestream #30
Merged
Filestream #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ready have unit tests for.
|
Putting this up here for some CR. I got frustrated trying to get the file streaming working with 2.6, but I will give it a try later this week. |
|
Why did you re-add all the dynamic function constructors? I thought we were getting away from those? https://github.com/ipfs/python-ipfs-api/pull/30/files#diff-33e409056abcd2472116a6860bf25cafR43 |
|
I didn't re-add them, I just made the methods wrap calls to those functions so that we could add helpful docstrings. I agree with you that decorators are confusing, and this is the same thing the decorators did but hopefully more readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes file streaming so that file uploads and downloads are chunked. Also added support for the get command to download files straight to disk. Fixes #2 and #28.