Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

feat: switch to async await #24

Merged
merged 4 commits into from
May 17, 2019
Merged

feat: switch to async await #24

merged 4 commits into from
May 17, 2019

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented Apr 24, 2019

Converts the importer to async/await

  • Shim importer with pull-stream-to-async-iterator
  • Convert tests to async/await
  • Convert importer to async/await and remove shim
  • Update README with API changes

Requires ipfs-inactive/js-ipfs-unixfs-exporter#21 to be merged

@ghost ghost assigned achingbrain Apr 24, 2019
@ghost ghost added the in progress label Apr 24, 2019
@achingbrain
Copy link
Collaborator Author

Ref: ipfs/js-ipfs#1670

Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

src/utils/persist.js Outdated Show resolved Hide resolved
test/importer-flush.spec.js Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 2a40ecb into master May 17, 2019
@achingbrain achingbrain deleted the async-await branch May 17, 2019 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants