This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
chore: async await refactor #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
November 20, 2019 23:25
|
Thanks @PedroMiguelSS - just a minor point for the future, these commits should be prefixed with I'll take a look at this now. |
alanshaw
suggested changes
Nov 21, 2019
added 5 commits
November 22, 2019 15:55
added 14 commits
November 22, 2019 15:59
added 3 commits
November 22, 2019 16:26
The assertion was commented out temporarly due to bootstrap.rm bug that was fixed here ipfs/js-ipfs#2626
PedroMiguelSS
force-pushed
the
chore/async-await-refactor
branch
2 times, most recently
from
f0be599
to
a25a2cc
Compare
PedroMiguelSS
force-pushed
the
chore/async-await-refactor
branch
from
a25a2cc
to
2720e57
Compare
alanshaw
approved these changes
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the tests to use async/await syntax.
Closes #526.
The tests' setup was not changed because #541 is already doing that.
This PR replaces the old #547. The difference is that this one doesn't depend on
feat/interface-testsbranch, which depends on a currently WIP branch - ipfs/js-ipfsd-ctl#395.This way we can merge this refactor as soon as it gets approved.