libbpf-tools: minor klockstat changes #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2022 14:39
Threads wait on mutexes; they don't spin. Signed-off-by: Barret Rhoden <brho@google.com>
Both mutex_lock_killable() and mutex_lock_interruptible() can be aborted. Their fexit return value is 0 if they acquired the mutex. Signed-off-by: Barret Rhoden <brho@google.com>
brho
requested review from
4ast,
brendangregg,
davemarchevsky,
drzaeus77,
goldshtn and
yonghong-song
as code owners
davemarchevsky
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
@brho mind if we tag you in future PRs that touch this tool?
|
On 2022-01-17 at 0:13 Dave Marchevsky wrote:
@brho mind if we tag you in future PRs that touch this tool?
Sounds good to me, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly just support for mutex_lock_{killable,interruptible}