libbpf-tools/klockstat: no more rlimit bumping + add comment #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR adding the libbpf-tools port of klockstat was sitting in a mergeable state for some time. Meanwhile, libbpf stopped exposing rlimit_memlock bumping API and now does the rlimit bump automatically if necessary. So remove the bump_rlimit_memlock call and set libbpf strict mode for this tool. Also, add a comment (from @brho's PR summary in iovisor#3688) detailing the differences in default behavior between the libbpf-tools and bcc-python versions. Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
davemarchevsky
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
@yonghong-song I'm going to merge this when tests are green in order to get master branch to a green state, but FYI |
Sure. sounds good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adding the libbpf-tools port of klockstat was sitting in a
mergeable state for some time. Meanwhile, libbpf stopped exposing
rlimit_memlock bumping API and now does the rlimit bump automatically if
necessary. So remove the bump_rlimit_memlock call and set libbpf strict
mode for this tool.
Also, add a comment (from @brho's PR summary in #3688) detailing the
differences in default behavior between the libbpf-tools and bcc-python
versions.
Signed-off-by: Dave Marchevsky davemarchevsky@fb.com