libbpf-tools: Support verbose mode and set custom libbpf print callback #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support verbose mode and set custom libbpf print callback in bashreadline. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in bindsnoop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in exitsnoop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in filetop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in funclatency. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in gethostlatency. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in ksnoop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in mountsnoop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in solisten. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Support verbose mode and set custom libbpf print callback in statsnoop. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Update all tools to make libbpf_print_fn function static. While at it, also keep the function signature in a single line since they fit in a 100-character line. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
chenhengqi
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
@davemarchevsky Please take a look. Thanks. |
davemarchevsky
approved these changes
Dec 29, 2021
| @@ -251,7 +252,7 @@ static int get_func_btf(struct btf *btf, struct func *func) | |||
| return 0; | |||
| } | |||
|
|
|||
| int predicate_to_value(char *predicate, struct value *val) | |||
There was a problem hiding this comment.
I'm fine with this change, but can you confirm that it's independent of the others in this file? If it's not, then I must be confused
There was a problem hiding this comment.
Yes, it's independent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verbose option and set custom libbpf print callback in all tools.
This would allow user to print libbpf debug log and aid the debugging
process.