Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated usdt_sample for ubuntu 21.10 (and python3) #3765

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Updated usdt_sample for ubuntu 21.10 (and python3) #3765

merged 1 commit into from
Dec 29, 2021

Conversation

bveldhoen
Copy link
Contributor

  • Updated readme for Ubuntu 21.10 and python3.
  • Readability improvements.
  • Using atomic_increment (thus requires bcc 0.21+).
  • Using/tested probes created using systemtap (dtrace), next to the
    probes created with macros in the folly header.
  • Also tested while building usdt_sample with clang.
  • Some (modern) cmake changes.
  • Added script to execute build and sample python scripts.

@yonghong-song
Copy link
Collaborator

@davemarchevsky could you take a look?

@davemarchevsky davemarchevsky self-assigned this Dec 20, 2021
davemarchevsky
davemarchevsky reviewed Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@davemarchevsky davemarchevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from nits LGTM

davemarchevsky
davemarchevsky requested changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@davemarchevsky davemarchevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see requested nit changes above, accidentally marked previous review as a 'comment'

@bveldhoen
Updated usdt_sample for ubuntu 21.10 (and python3)
d624578 
* Updated readme for Ubuntu 21.10 and python3.
* Readability improvements.
* Using atomic_increment (thus requires bcc 0.21+).
* Using/tested probes created using systemtap (dtrace), next to the
probes created with macros in the folly header.
* Also tested while building usdt_sample with clang.
* Some (modern) cmake changes.
* Added script to execute build and sample python scripts.
@bveldhoen
Copy link
Contributor Author

Updated the underlying commit, please re-review.

@davemarchevsky davemarchevsky merged commit 9adb763 into iovisor:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemarchevsky davemarchevsky davemarchevsky requested changes

@4ast 4ast Awaiting requested review from 4ast 4ast is a code owner

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

@drzaeus77 drzaeus77 Awaiting requested review from drzaeus77 drzaeus77 is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@yonghong-song yonghong-song Awaiting requested review from yonghong-song yonghong-song is a code owner

Assignees

@davemarchevsky davemarchevsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bveldhoen @yonghong-song @davemarchevsky