tools/readahead compatible with kernel version >= 5.10 #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyuezhou
requested review from
brendangregg,
goldshtn and
drzaeus77
as code owners
chenhengqi
reviewed
Jun 24, 2021
src/python/bcc/utils.py
Outdated
Comment on lines
27
to
33
| if version[0] > major: | ||
| return True | ||
| if version[0] < major: | ||
| return False | ||
| if minor and version[1] < minor: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
return (version[0], version[1]) > (major, minor)
There was a problem hiding this comment.
thanks! adjusted.
tools/readahead.py
Outdated
| from time import sleep | ||
| import ctypes as ct | ||
| import argparse | ||
|
|
||
| # arguments | ||
| examples = """examples: | ||
| ./readahead -d 20 # monitor for 10 seconds and generate stats | ||
| ./readahead -d 20 # monitor for 10 seconds and generate stats |
There was a problem hiding this comment.
20 and 10 don't match.
| if kernel_version_ge(5, 10): | ||
| ra_event = "do_page_cache_ra" | ||
| b.attach_kprobe(event=ra_event, fn_name="entry__do_page_cache_readahead") | ||
| b.attach_kretprobe(event=ra_event, fn_name="exit__do_page_cache_readahead") |
There was a problem hiding this comment.
Let us just do first try attach_kprobe with __do_page_cache_readahead(), if failed, try do_page_cache_ra(). You can look at nfsdist.py as an example.
|
[buildbot, test this please] |
brho
pushed a commit
to brho/bcc
that referenced
this pull request
Nov 3, 2021
After kernel version 5.10, __do_page_cache_readahead() was renamed to do_page_cache_ra(), let us try both in readahead.py.
ismhong
pushed a commit
to ismhong/bcc
that referenced
this pull request
Dec 6, 2021
After kernel version 5.10, __do_page_cache_readahead() was renamed to do_page_cache_ra(), let us try both in readahead.py.
ismhong
pushed a commit
to ismhong/bcc
that referenced
this pull request
Dec 6, 2021
After kernel version 5.10, __do_page_cache_readahead() was renamed to do_page_cache_ra(), let us try both in readahead.py.
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
After kernel version 5.10, __do_page_cache_readahead() was renamed to do_page_cache_ra(), let us try both in readahead.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After kernel version 5.10, __do_page_cache_readahead was renamed to /do_page_cache_ra https://patchwork.kernel.org/project/linux-fsdevel/patch/20200903140844.14194-5-willy@infradead.org/