feature: support create new map and pin it to bpffs as file(BPF_TABLE_PINNED) #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyuezhou
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
[buildbot, test this please] |
src/cc/libbpf.c
Outdated
| dname = strdup(path); | ||
| if (dname == NULL) { | ||
| return -ENOMEM; | ||
| } |
There was a problem hiding this comment.
just one line after if statement, let us remove {}.
src/cc/libbpf.c
Outdated
| dir = dirname(dname); | ||
| if (mkdir(dir, 0700) && errno != EEXIST) { | ||
| err = -errno; | ||
| } |
src/cc/libbpf.c
Outdated
| free(dname); | ||
| if (err) { | ||
| fprintf(stderr, "failed to mkdir %s: %s\n", path, strerror(-err)); | ||
| } |
There was a problem hiding this comment.
ditto for the rest code below.
There was a problem hiding this comment.
fixed for the rest code below.
|
[buildbot, ok to test] |
Hi @yonghong-song I've adjusted it. |
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
…_PINNED) (iovisor#3382) Support create a new map and pin it if the pinned file is not available. Co-authored-by: chenyue.zhou <chenyue.zhou@upai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3373
In function
VisitVarDecl. If bpf_obj_get() returns an invalid fd, markedpinned_idto -1.In function
create_maps. Ifpinned_idless than 0, create a new map, ifpinned_idis -1 pin map fd to specified file.