tools/funclatency: Should clear() after display that is what we want #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG:
funclatency memcpy -i 2
nsecs : count distribution
0 -> 1 : 0 | |
2 -> 3 : 0 | |
4 -> 7 : 0 | |
8 -> 15 : 0 | |
16 -> 31 : 0 | |
32 -> 63 : 0 | |
64 -> 127 : 0 | |
128 -> 255 : 0 | |
256 -> 511 : 0 | |
512 -> 1023 : 0 | |
1024 -> 2047 : 0 | |
2048 -> 4095 : 28 |************ |
4096 -> 8191 : 92 |****************************************|
avg = 4265 nsecs, total: 9413985 nsecs, count: 2207
nsecs : count distribution
0 -> 1 : 0 | |
2 -> 3 : 0 | |
4 -> 7 : 0 | |
8 -> 15 : 0 | |
16 -> 31 : 0 | |
32 -> 63 : 0 | |
64 -> 127 : 0 | |
128 -> 255 : 0 | |
256 -> 511 : 0 | |
512 -> 1023 : 0 | |
1024 -> 2047 : 0 | |
2048 -> 4095 : 38 |****** |
4096 -> 8191 : 248 |****************************************|
avg = 4304 nsecs, total: 11066321 nsecs, count: 2571
After long-run, you can see the count above is totally wrong.
Also, display together before together clearing is important for better accuracy.
Signed-off-by: Edward Wu <edwardwu@realtek.com>
|
[buildbot, test this please] |
|
Thanks for the fix! Yes, we do need to clear the avg table between the interval of runs. |
ismhong
pushed a commit
to ismhong/bcc
that referenced
this pull request
Dec 6, 2021
…ovisor#3380) BUG: funclatency memcpy -i 2 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 28 |************ | 4096 -> 8191 : 92 |****************************************| avg = 4265 nsecs, total: 9413985 nsecs, count: 2207 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 38 |****** | 4096 -> 8191 : 248 |****************************************| avg = 4304 nsecs, total: 11066321 nsecs, count: 2571 After long-run, you can see the count above is totally wrong. Also, display together before together clearing is important for better accuracy. Change-Id: I702db2733f4e9266264eb1fe56a73191abd42012 Signed-off-by: Edward Wu <edwardwu@realtek.com>
ismhong
pushed a commit
to ismhong/bcc
that referenced
this pull request
Dec 6, 2021
…ovisor#3380) BUG: funclatency memcpy -i 2 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 28 |************ | 4096 -> 8191 : 92 |****************************************| avg = 4265 nsecs, total: 9413985 nsecs, count: 2207 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 38 |****** | 4096 -> 8191 : 248 |****************************************| avg = 4304 nsecs, total: 11066321 nsecs, count: 2571 After long-run, you can see the count above is totally wrong. Also, display together before together clearing is important for better accuracy. Change-Id: I75ea8fb0e90101cf82f38861fa752d48c8979843 Signed-off-by: Edward Wu <edwardwu@realtek.com>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
…ovisor#3380) BUG: funclatency memcpy -i 2 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 28 |************ | 4096 -> 8191 : 92 |****************************************| avg = 4265 nsecs, total: 9413985 nsecs, count: 2207 nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 38 |****** | 4096 -> 8191 : 248 |****************************************| avg = 4304 nsecs, total: 11066321 nsecs, count: 2571 After long-run, you can see the count above is totally wrong. Also, display together before together clearing is important for better accuracy. Signed-off-by: Edward Wu <edwardwu@realtek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:
funclatency memcpy -i 2
nsecs : count distribution
0 -> 1 : 0 | |
2 -> 3 : 0 | |
4 -> 7 : 0 | |
8 -> 15 : 0 | |
16 -> 31 : 0 | |
32 -> 63 : 0 | |
64 -> 127 : 0 | |
128 -> 255 : 0 | |
256 -> 511 : 0 | |
512 -> 1023 : 0 | |
1024 -> 2047 : 0 | |
2048 -> 4095 : 28 |************ |
4096 -> 8191 : 92 |****************************************|
avg = 4265 nsecs, total: 9413985 nsecs, count: 2207
avg = 4304 nsecs, total: 11066321 nsecs, count: 2571
After long-run, you can see the count above is totally wrong.
Also, display together before together clearing is important for better accuracy.
Signed-off-by: Edward Wu edwardwu@realtek.com