Miscellaneous fixes #1914
Merged
Miscellaneous fixes #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a buffer overflow in get_pid_exe(), a use-after-free error in bcc_usdt_get_probe_argctype() and a possible NULL pointer dereference in find_debug_via_debuglink().
Leaked file descriptors in bpf_attach_uprobe() and verify_checksum(). Memory leaks in Parser::func_add() and bcc_procutils_language().
jeromemarchand
requested review from
4ast,
drzaeus77 and
yonghong-song
as code owners
src/cc/bcc_proc.c
Outdated
| @@ -446,8 +446,10 @@ const char *bcc_procutils_language(int pid) { | |||
| while (isspace(mapname[0])) mapname++; | |||
| for (i = 0; i < nb_languages; i++) { | |||
| snprintf(pathname, sizeof(pathname), "/lib%s", languages[i]); | |||
| if (strstr(mapname, pathname)) | |||
| if (strstr(mapname, pathname)) { | |||
| fclose(procfile); | |||
There was a problem hiding this comment.
Could you correct the indentation for the above fclose(procfile)?
|
[buildbot, ok to test] |
1 similar comment
|
[buildbot, ok to test] |
|
[buildbot, ok to test] |
1 similar comment
|
[buildbot, ok to test] |
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
* Fix multiple memory access errors Fixes a buffer overflow in get_pid_exe(), a use-after-free error in bcc_usdt_get_probe_argctype() and a possible NULL pointer dereference in find_debug_via_debuglink(). * Fix multiple ressource leaks Leaked file descriptors in bpf_attach_uprobe() and verify_checksum(). Memory leaks in Parser::func_add() and bcc_procutils_language(). * fixup! Fix multiple ressource leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few bug uncovered by a Coverity scan: some leaks and more importantly some memory access errors.