clang: loader: Allow user to override kernel version #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCC currently requires exactly matching headers. Sometimes this is quite inconvenient especially if the kernel version is only very slightly different such as updates in a stable kernel. This patch gives the user the flexibility to override the the LINUX_VERSION_CODE provided in the linux kernel headers, so that the eBPF program may load. We also print a message when this is done, so that the user is warned about the override happening and that results may be unpredictable. Also updated the docs. Signed-off-by: Joel Fernandes <joel@joelfernandes.org>
joelagnel
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
This same as the previous PR #1880 which got closed. It has got LGTMs with minor nits corrected, all checks were passed in the old PR so safe to merge. |
|
[buildbot, ok to test] |
yonghong-song
approved these changes
Jul 24, 2018
|
Thanks @joelagnel will merge once the test passed. The github won't allow to merge without passing tests. |
|
I understand, thanks! |
jeromemarchand
added a commit
to jeromemarchand/bcc
that referenced
this pull request
Feb 5, 2019
A few files that are obviously not executable have the exec bit set. Most those files were created with faulty mode to begin with, but src/cc/export/helpers.h and src/cc/frontends/clang/loader.cc have had their exec bit (unintendedly I assume) set by commit bfecc24 ("clang: loader: Allow user to override kernel version (iovisor#1895)").
yonghong-song
pushed a commit
that referenced
this pull request
Feb 5, 2019
A few files that are obviously not executable have the exec bit set. Most those files were created with faulty mode to begin with, but src/cc/export/helpers.h and src/cc/frontends/clang/loader.cc have had their exec bit (unintendedly I assume) set by commit bfecc24 ("clang: loader: Allow user to override kernel version (#1895)").
palexster
pushed a commit
to palexster/bcc
that referenced
this pull request
Jul 7, 2019
A few files that are obviously not executable have the exec bit set. Most those files were created with faulty mode to begin with, but src/cc/export/helpers.h and src/cc/frontends/clang/loader.cc have had their exec bit (unintendedly I assume) set by commit bfecc24 ("clang: loader: Allow user to override kernel version (iovisor#1895)").
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
BCC currently requires exactly matching headers. Sometimes this is quite inconvenient especially if the kernel version is only very slightly different such as updates in a stable kernel. This patch gives the user the flexibility to override the the LINUX_VERSION_CODE provided in the linux kernel headers, so that the eBPF program may load. We also print a message when this is done, so that the user is warned about the override happening and that results may be unpredictable. Also updated the docs. Signed-off-by: Joel Fernandes <joel@joelfernandes.org>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
A few files that are obviously not executable have the exec bit set. Most those files were created with faulty mode to begin with, but src/cc/export/helpers.h and src/cc/frontends/clang/loader.cc have had their exec bit (unintendedly I assume) set by commit bfecc24 ("clang: loader: Allow user to override kernel version (iovisor#1895)").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCC currently requires exactly matching headers. Sometimes this is quite
inconvenient especially if the kernel version is only very slightly
different such as updates in a stable kernel. This patch gives the user
the flexibility to override the the LINUX_VERSION_CODE provided in the
linux kernel headers, so that the eBPF program may load. We also print a
message when this is done, so that the user is warned about the override
happening and that results may be unpredictable.
Also updated the docs.
Signed-off-by: Joel Fernandes joel@joelfernandes.org