[blockindex] remove DeleteTipBlock()

[dustinxie]

Description

as discussed, DeleteTipBlock() is not meaningful for indexers, so remove this from interface.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

• [] Bug fix (non-breaking change which fixes an issue)
• [] New feature (non-breaking change which adds functionality)
• Code refactor or improvement
• [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
• [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• make test
• [] fullsync
• [] Other test (please specify)

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• [] My code follows the style guidelines of this project
• [] I have performed a self-review of my code
• [] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [] My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works
• [] New and existing unit tests pass locally with my changes
• [] Any dependent changes have been merged and published in downstream modules

[CoderZhi]

we can delete the function from the interface, but we may leave the implementations as they are.

[dustinxie]

we can delete the function from the interface, but we may leave the implementations as they are.

since the interface is removed, may I know the reason why we want to keep the implementation? some implementation requires methods like Revert() of underlying structs (which can also be moved), and extra input parameters and code to implement. IMO removing the implementations can clean-up the code better

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud