[staking] Cannot withdraw endorsement if it is withdrawing #4179
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4179 +/- ##
==========================================
+ Coverage 75.38% 76.11% +0.73%
==========================================
Files 303 340 +37
Lines 25923 29229 +3306
==========================================
+ Hits 19541 22248 +2707
- Misses 5360 5872 +512
- Partials 1022 1109 +87 ☔ View full report in Codecov by Sentry. |
| return validateBucketEndorsementByStatus(esm, bucket, status, height) | ||
| } | ||
|
|
||
| func validateBucketEndorsementByStatus(esm *EndorsementStateManager, bucket *VoteBucket, status EndorsementStatus, height uint64) ReceiptError { |
There was a problem hiding this comment.
Efficiency is not the first thing to consider in this case, thus this refactor is not suggested.
| return &handleError{ | ||
| err: errors.New("bucket is already endorsed"), | ||
| err: errors.Errorf("bucket endorsement is not in status %d", status), |
There was a problem hiding this comment.
it is very confusing especially in this return error.
There was a problem hiding this comment.
add EndorsementStatus.String() method to improve readability
| @@ -118,14 +118,14 @@ func TestValidateBucket(t *testing.T) { | |||
| // endorsed bucket | |||
| r.NoError(esm.Put(bktIdx, &Endorsement{ExpireHeight: endorsementNotExpireHeight})) | |||
| r.Nil(validateBucketEndorsement(esm, bkt, true, blkHeight)) | |||
| r.ErrorContains(validateBucketEndorsement(esm, bkt, false, blkHeight), "bucket is already endorsed") | |||
| r.ErrorContains(validateBucketEndorsement(esm, bkt, false, blkHeight), "bucket endorsement is not in status 9") | |||
There was a problem hiding this comment.
for example, 9 is not straightforward to understand
| failureStatus: iotextypes.ReceiptStatus_ErrUnknown, | ||
| } | ||
| } | ||
| if status != Endorsed && status != UnEndorsing { |
There was a problem hiding this comment.
Can be simplified if status == EndorseExpired
|
Description
PR includes the following changes:
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: