add unit test and fix a log error

Author: CoderZhi

action/protocol/staking/protocol.go

@@ -299,7 +299,7 @@ func (p *Protocol) Start(ctx context.Context, sr protocol.StateReader) (protocol
 			}
 			view, err := NewContractStakeViewBuilder(indexer, p.blockStore).Build(ctx, sr, height)
 			if err != nil {
-				errChan <- errors.Wrapf(err, "failed to create stake view for contract %s", p.contractStakingIndexer.ContractAddress())
+				errChan <- errors.Wrapf(err, "failed to create stake view for contract %s", indexer.ContractAddress())
 				return
 			}
 			callback(view)

action/protocol/staking/protocol_test.go

@@ -314,6 +314,58 @@ func Test_CreatePreStatesWithRegisterProtocol(t *testing.T) {
 	require.NoError(p.CreatePreStates(ctx, sm))
 }
 
+func TestCreatePreStatesMigration(t *testing.T) {
+	require := require.New(t)
+	ctrl := gomock.NewController(t)
+	sm := testdb.NewMockStateManager(ctrl)
+	g := genesis.TestDefault()
+	mockView := NewMockContractStakeView(ctrl)
+	mockContractStaking := NewMockContractStakingIndexer(ctrl)
+	mockContractStaking.EXPECT().ContractAddress().Return(identityset.Address(1)).Times(1)
+	mockContractStaking.EXPECT().LoadStakeView(gomock.Any(), gomock.Any()).Return(mockView, nil).Times(1)
+	mockContractStaking.EXPECT().StartHeight().Return(uint64(0)).Times(1)
+	mockContractStaking.EXPECT().Height().Return(uint64(0), nil).Times(1)
+	p, err := NewProtocol(HelperCtx{
+		DepositGas:    nil,
+		BlockInterval: getBlockInterval,
+	}, &BuilderConfig{
+		Staking:                       g.Staking,
+		PersistStakingPatchBlock:      math.MaxUint64,
+		SkipContractStakingViewHeight: math.MaxUint64,
+		Revise: ReviseConfig{
+			VoteWeight:    g.Staking.VoteWeightCalConsts,
+			ReviseHeights: []uint64{g.GreenlandBlockHeight}},
+	}, nil, nil, nil, mockContractStaking)
+	require.NoError(err)
+	ctx := genesis.WithGenesisContext(context.Background(), g)
+	ctx = protocol.WithBlockCtx(
+		ctx,
+		protocol.BlockCtx{
+			BlockHeight: g.ToBeEnabledBlockHeight,
+		},
+	)
+	ctx = protocol.WithFeatureCtx(protocol.WithFeatureWithHeightCtx(ctx))
+	v, err := p.Start(ctx, sm)
+	require.NoError(err)
+	require.NoError(sm.WriteView(_protocolID, v))
+	mockView.EXPECT().Migrate(gomock.Any(), gomock.Any()).Return(errors.New("migration error")).Times(1)
+	require.ErrorContains(p.CreatePreStates(ctx, sm), "migration error")
+	mockView.EXPECT().Migrate(gomock.Any(), gomock.Any()).Return(nil).Times(1)
+	require.NoError(p.CreatePreStates(ctx, sm))
+	require.NoError(p.CreatePreStates(protocol.WithBlockCtx(
+		ctx,
+		protocol.BlockCtx{
+			BlockHeight: g.ToBeEnabledBlockHeight - 1,
+		},
+	), sm))
+	require.NoError(p.CreatePreStates(protocol.WithBlockCtx(
+		ctx,
+		protocol.BlockCtx{
+			BlockHeight: g.ToBeEnabledBlockHeight + 1,
+		},
+	), sm))
+}
+
 func Test_CreateGenesisStates(t *testing.T) {
 	require := require.New(t)
 	ctrl := gomock.NewController(t)