eth/catalyst: fix flaw in withdrawal-gathering in simulated beacon (ethereum#29344)

AaronChen0 · jorgemmsilva · commit f00cbcaf1ba0 · 2024-06-17T13:51:42.000+01:00
return after reaching maxCount
diff --git a/eth/catalyst/simulated_beacon.go b/eth/catalyst/simulated_beacon.go
@@ -63,7 +63,7 @@ func (w *withdrawalQueue) gatherPending(maxCount int) []*types.Withdrawal {
 		case withdrawal := <-w.pending:
 			withdrawals = append(withdrawals, withdrawal)
 			if len(withdrawals) == maxCount {
-				break
+				return withdrawals
 			}
 		default:
 			return withdrawals

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func (w withdrawalQueue) gatherPending(maxCount int) []types.Withdrawal {`
`63`	`63`	`case withdrawal := <-w.pending:`
`64`	`64`	`withdrawals = append(withdrawals, withdrawal)`
`65`	`65`	`if len(withdrawals) == maxCount {`
`66`		`- break`
	`66`	`+ return withdrawals`
`67`	`67`	`}`
`68`	`68`	`default:`
`69`	`69`	`return withdrawals`