ProposedTransaction.__init__ now convert tag value to a Tag object #151
Conversation
There was a problem hiding this comment.
Hey @rpitonak thank you for submitting this fix!
Could we also include a unit test, so that we can make sure we don't inadvertently introduce a regression in future versions of the software?
iota/transaction/creation.py
Outdated
| last_index = len(self) - 1 | ||
|
|
||
| # type: Tuple[int, ProposedTransaction] | ||
| for (i, txn) in enumerate(self): |
There was a problem hiding this comment.
❔ Does the type hint work when it's on the line preceding the for loop? I thought it had to go on the same line.
There was a problem hiding this comment.
Example:
Type hint placed on the previous line — note that IDE autocomplete doesn't work:
Type hint placed at the end of the line — now IDE autocomplete works as expected.
|
Hey @todofixthis thank you for the review. The type hint is already fixed. I will send another commit with Unit test. |
|
Hey Radoslav. Because this PR also includes PEP-8 formatting changes, could you also follow-up with the developers working on #147 to make sure that any conflicts can be resolved before I merge this? |
ProposedTransaction.__init__ now convert tag value to a Tag object
tagvalue to aTagobject #100I will be glad for the comments and suggestions.