Continue removing files after an error

The fix is to skip removing FIFOs had a side-effect of failing to remove
a directory where a skipped file is because the directory is not empty.

The change here is to continue removing files after errors, which is
also helpful in cases when `ios-deploy` fails to remove `/Documents/`
("Error 0xa: You do not have permission."), but still needs to continue
removing what it can from `/Library/`.

Author: eunikolsky

src/ios-deploy/ios-deploy.m

@@ -148,6 +148,20 @@
         }                                                                       \
     } while (false);
 
+// Checks for MobileDevice.framework errors and tries to print them.
+#define log_error(call)                                                       \
+    do {                                                                        \
+        unsigned int err = (unsigned int)call;                                  \
+        if (err != 0)                                                           \
+        {                                                                       \
+            const char* msg = get_error_message(err);                           \
+            NSString *description = msg ? [NSString stringWithUTF8String:msg] : @"unknown."; \
+            NSLogJSON(@{@"Event": @"Error", @"Code": @(err), @"Status": description}); \
+            log_on_error(@"Error 0x%x: %@ " #call, err, description);               \
+        }                                                                       \
+    } while (false);
+
+
 
 void disable_ssl(ServiceConnRef con)
 {
@@ -163,6 +177,18 @@ void disable_ssl(ServiceConnRef con)
     con->sslContext = NULL;
 }
 
+void log_on_error(NSString* format, ...)
+{
+    va_list valist;
+    va_start(valist, format);
+    NSString* str = [[[NSString alloc] initWithFormat:format arguments:valist] autorelease];
+    va_end(valist);
+
+    if (!_json_output) {
+        NSLog(@"[ !! ] %@", str);
+    }
+}
+
 
 void on_error(NSString* format, ...)
 {
@@ -2037,7 +2063,7 @@ void rmtree_callback(AFCConnectionRef conn, const char *name, read_dir_cb_reason
 {
     if (reason == READ_DIR_FILE || reason == READ_DIR_AFTER_DIR) {
         NSLogVerbose(@"Deleting %s", name);
-        check_error(AFCRemovePath(conn, name));
+        log_error(AFCRemovePath(conn, name));
     } else if (reason == READ_DIR_FIFO) {
         NSLogVerbose(@"Skipping %s", name);
     }