Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msbuildproperties #1832

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Msbuildproperties #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a604e5
OpenTelemetry settings
TheAngryByrd Feb 25, 2023
209ae4a
initial msbuild properties support
TheAngryByrd Feb 25, 2023
1ff8aec
use simple object for msbuild properties to get UI
TheAngryByrd Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions release/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,18 @@
"scope": "window",
"type": "string"
},
"FSharp.buildOptions.msBuildProperties": {
"type": "object",
"description": "An array of MSBuild properties to set at design time load.",
"additionalProperties": {
"type" : "string"
},
"default":
{
"Configuration": "Debug"
}

},
"FSharp.codeLenses.references.enabled": {
"description": "If enabled, code lenses for reference counts for methods and functions will be shown.",
"type": "boolean",
Expand Down Expand Up @@ -514,10 +526,10 @@
"description": "Appends the \u0027--attachdebugger\u0027 argument to fsac, this will allow you to attach a debugger.",
"type": "boolean"
},
"FSharp.fsac.conserveMemory" : {
"default" : false,
"FSharp.fsac.conserveMemory": {
"default": false,
"description": "Configures FsAutoComplete with settings intended to reduce memory consumption. Requires restart.",
"type" : "boolean"
"type": "boolean"
},
"FSharp.fsac.dotnetArgs": {
"default": [],
Expand All @@ -533,10 +545,10 @@
"scope": "machine-overridable",
"type": "string"
},
"FSharp.fsac.parallelReferenceResolution" : {
"default" : false,
"FSharp.fsac.parallelReferenceResolution": {
"default": false,
"description": "EXPERIMENTAL: Speed up analyzing of projects in parallel. Requires restart.",
"type" : "boolean"
"type": "boolean"
},
"FSharp.fsac.silencedLogs": {
"default": [],
Expand Down Expand Up @@ -665,6 +677,27 @@
"description": "Automatically shows the MSBuild output panel when MSBuild functionality is invoked",
"type": "boolean"
},
"FSharp.notifications.trace": {
"default": false,
"description": "Enables more verbose notifications using System.Diagnostics.Activity to view traces from FSharp.Compiler.Service.",
"type": "boolean"
},
"FSharp.notifications.traceNamespaces": {
"default": [
"BoundModel.TypeCheck",
"BackgroundCompiler."
],
"description": "The set of System.Diagnostics.Activity names to watch.",
"type": "array",
"required": [
"FSharp.notifications.trace"
]
},
"FSharp.openTelemetry.enabled": {
"default": false,
"description": "Enables OpenTelemetry exporter. See https://opentelemetry.io/docs/reference/specification/protocol/exporter/ for environment variables to configure for the exporter. Requires Restart.",
"type": "boolean"
},
"FSharp.pipelineHints.enabled": {
"default": true,
"description": "Enables PipeLine hints, which are like LineLenses that appear along each step of a chain of piped expressions",
Expand Down
5 changes: 5 additions & 0 deletions src/Core/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,9 @@ Consider:
let enableAdaptiveLspServer =
"FSharp.enableAdaptiveLspServer" |> Configuration.get false

let openTelemetryEnabled =
"FSharp.openTelemetry.enabled" |> Configuration.get false

let enableProjectGraph =
"FSharp.enableMSBuildProjectGraph" |> Configuration.get false

Expand Down Expand Up @@ -807,6 +810,8 @@ Consider:
yield "--project-graph-enabled"
if enableAdaptiveLspServer then
yield "--adaptive-lsp-server-enabled"
if openTelemetryEnabled then
yield "--otel-exporter-enabled"
if verbose then
yield "--verbose"
if fsacSilencedLogs <> null && fsacSilencedLogs.Length > 0 then
Expand Down