-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test explorer #1671
Test explorer #1671
Conversation
Just force-pushed a rebase onto latest main so that I can use the VSCode task mechanism to execute the build command, @nojaf. You may need to |
@nojaf I think there's actually a gap in the API here: we can't easily collect process/task execution status currently: microsoft/vscode#97475 I think given that limitation it's ok to keep the current msbuild execution mechanism. |
Hey @baronfel, I'm trying to pick up the pieces here. |
@nojaf we were already using the progress APIs in the MSBuild API you were calling, so I fleshed out that API to be a bit more descriptive. What do you think? If you wanted to, you could also use progress on the test running specifically. |
I tried the notifications instead, I found that a bit more visible. |
This is by no means a perfect implementation but might be sufficient for a first release. |
That seems fine to me, though (note to self) we should document that on the ionide.io website when writing docs for this feature/release. |
I spent some time with this this morning, and I definitely think it works well enough for a first release. There are some additional enhancements that can come after (debugging tests is the big one that comes to mind), but this is already a great addition. |
I'm trying to get the NUnit tests working.
Still a lot of work that needs to be done.
I've made a change in the approach, I think it makes more sense to group all the tests underneath the individual projects.
I'm also not the biggest fan of the testing API, I found myself needing additional data every step along the way.
Anyway @baronfel, @Krzysztof-Cieslak let me know if I'm heading in the right direction.
I could use a hint in the best way to run the tests and process the output.