Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test explorer #1671

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Test explorer #1671

merged 12 commits into from
Apr 14, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 21, 2022

I'm trying to get the NUnit tests working.
Still a lot of work that needs to be done.
I've made a change in the approach, I think it makes more sense to group all the tests underneath the individual projects.
I'm also not the biggest fan of the testing API, I found myself needing additional data every step along the way.

Anyway @baronfel, @Krzysztof-Cieslak let me know if I'm heading in the right direction.
I could use a hint in the best way to run the tests and process the output.

@baronfel
Copy link
Contributor

baronfel commented Apr 5, 2022

Just force-pushed a rebase onto latest main so that I can use the VSCode task mechanism to execute the build command, @nojaf. You may need to git pull --rebase next time you refresh

@baronfel
Copy link
Contributor

baronfel commented Apr 5, 2022

@nojaf I think there's actually a gap in the API here: we can't easily collect process/task execution status currently: microsoft/vscode#97475

I think given that limitation it's ok to keep the current msbuild execution mechanism.

@nojaf
Copy link
Contributor Author

nojaf commented Apr 6, 2022

Hey @baronfel, I'm trying to pick up the pieces here.
Any idea how I can show the user that we are invoking MSBuild to build and later run the tests?

@baronfel
Copy link
Contributor

baronfel commented Apr 7, 2022

@nojaf perhaps the progress APIs would be a good mechanism? we use it in a few areas of the codebase already so you could draw inspiration from there

@baronfel
Copy link
Contributor

baronfel commented Apr 10, 2022

@nojaf we were already using the progress APIs in the MSBuild API you were calling, so I fleshed out that API to be a bit more descriptive. What do you think? If you wanted to, you could also use progress on the test running specifically.

@nojaf
Copy link
Contributor Author

nojaf commented Apr 10, 2022

I tried the notifications instead, I found that a bit more visible.
But I would be ok to change this.
Thanks for the pointers here Chet, finally made some progress again (pun intended).

@nojaf nojaf marked this pull request as ready for review April 10, 2022 10:19
@nojaf
Copy link
Contributor Author

nojaf commented Apr 10, 2022

This is by no means a perfect implementation but might be sufficient for a first release.
All tests are run via dotnet test, even the Expecto ones.
This way, there is no special code for any framework. To start with this seems plausible.

@nojaf nojaf changed the title [WIP] Test explorer Test explorer Apr 10, 2022
@baronfel
Copy link
Contributor

That seems fine to me, though (note to self) we should document that on the ionide.io website when writing docs for this feature/release.

@baronfel
Copy link
Contributor

I spent some time with this this morning, and I definitely think it works well enough for a first release. There are some additional enhancements that can come after (debugging tests is the big one that comes to mind), but this is already a great addition.

@baronfel baronfel merged commit 639b9c0 into ionide:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants