Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReplaceLambdaWithDotLambda code fix #1251

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add ReplaceLambdaWithDotLambda code fix #1251

merged 2 commits into from
Mar 28, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 22, 2024 •
edited
Loading

dotLambda

If someone has some more test cases in mind don't be shy.

Fixes #1194

@TheAngryByrd
Copy link
Member

I know compiler complains of you already have a _ in scope sometimes else. Like (fun _ v -> v |> List,collect (_.Things))

@nojaf nojaf force-pushed the ReplaceLambdaWithDotLambda branch from 27f76d4 to 8360060 Compare March 25, 2024 07:15
@nojaf nojaf changed the base branch from main to nightly March 25, 2024 07:15
@nojaf
Copy link
Contributor Author

nojaf commented Mar 25, 2024

Yeah, there have been some fixes in this area for 8.0.300.
Going to target nightly branch instead.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 28, 2024

Ready for review.

@TheAngryByrd
Copy link
Member

Thank you!!

@TheAngryByrd TheAngryByrd merged commit e5201d2 into ionide:nightly Mar 28, 2024
12 of 14 checks passed
@nojaf nojaf mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code-fix for _.Property / _.MethodCall() / _.IndexerAccess[idx] shorthand for accessor functions
2 participants
@nojaf @TheAngryByrd