Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore expression code fix #1253

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Ignore expression code fix #1253

merged 9 commits into from
Apr 12, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 25, 2024

IgnoreExpression

@nojaf
Copy link
Contributor Author

nojaf commented Mar 28, 2024

Ready for review.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 28, 2024

Thanks for the input @brianrourkeboll!

@brianrourkeboll brianrourkeboll mentioned this pull request Mar 28, 2024
Open
@brianrourkeboll brianrourkeboll mentioned this pull request Apr 1, 2024
Merged
2 tasks
@nojaf nojaf mentioned this pull request Apr 8, 2024
Closed
@nojaf
Copy link
Contributor Author

nojaf commented Apr 8, 2024

Ready for review.

TheAngryByrd
TheAngryByrd approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nojaf
Copy link
Contributor Author

nojaf commented Apr 12, 2024

@TheAngryByrd how about merging this one in?

@TheAngryByrd TheAngryByrd merged commit b5fa4aa into ionide:nightly Apr 12, 2024
13 of 14 checks passed
@TheAngryByrd
Copy link
Member

Hmm for some reason I thought I did. Thanks for the reminder!

@nojaf
Copy link
Contributor Author

nojaf commented Apr 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

@brianrourkeboll brianrourkeboll brianrourkeboll approved these changes

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nojaf @TheAngryByrd @baronfel @brianrourkeboll